Compile problems with current angband git version

[SaThaRiel]

Hi,

i waited for some days/weeks now to see if this problem "solves itself" but i'm still getting errors when linking angband. I know that this is a possible problem when trying to build from source but since there hasn't been a change since days now i wonder if someone is aware of it:

[...]
Successfully compiled z-virt.c.
      LINK angband.o           
In file included from gtk/cairo-utils.h:25:0,
                 from gtk/main-gtk.h:30,
                 from gtk/main-gtk.c:22:
/usr/include/cairo/cairo.h:1976:26: warning: comma at end of enumerator list
gtk/main-gtk.c: In function ‘last_inv_slot’:
gtk/main-gtk.c:2198:12: error: ‘inventory’ undeclared (first use in this function)
gtk/main-gtk.c:2198:12: note: each undeclared identifier is reported only once for each function it appears in
gtk/main-gtk.c: In function ‘inv_slot’:
gtk/main-gtk.c:2218:11: error: ‘inventory’ undeclared (first use in this function)
gtk/main-gtk.c: In function ‘handle_inv’:
gtk/main-gtk.c:2287:25: error: ‘inventory’ undeclared (first use in this function)
gtk/main-gtk.c: In function ‘handle_equip’:
gtk/main-gtk.c:2326:25: error: ‘inventory’ undeclared (first use in this function)
gtk/main-gtk.c: In function ‘cr_print_equippy’:
gtk/main-gtk.c:2506:12: error: ‘inventory’ undeclared (first use in this function)
gtk/main-gtk.c: In function ‘handle_sidebar’:
gtk/main-gtk.c:2570:35: error: ‘c_name’ undeclared (first use in this function)
Failed to compile gtk/main-gtk.c!
make[3]: *** [gtk/main-gtk.o] Error 1
make[2]: *** [all] Error 1
make[1]: *** [subdirs] Error 1
make: *** [all] Error 1

gcc is 4.5.1, not sure what else may be useful.

[Magnate]

Can you confirm that you cloned from github.com/angband/angband.git? Can you tell me what arguments you gave to ./configure, if any?

I will look into this tomorrow - I'm not aware of any compilation issues in the current master branch.

[takkaria]

Originally Posted by Magnate

Can you confirm that you cloned from github.com/angband/angband.git? Can you tell me what arguments you gave to ./configure, if any?

I will look into this tomorrow - I'm not aware of any compilation issues in the current master branch.

looks like it's related to elly's changes of moving the global 'inventory' to be inside the player struct

[SaThaRiel]

I pulled from github.com/angband/angband.git (already existing repository) and also did a git clone (removed repository to start over).
The build is done this way

  ./autogen.sh
  ./configure \
    --prefix=/usr \
    --bindir=/usr/bin/ \
    --sysconfdir=/usr/share/angband \
    --with-configpath=/usr/share/angband \
    --with-libpath=/usr/share/angband \
    --enable-gtk \
    --enable-sdl \
	--enable-sdl-mixer || return 1
  make clean
  make

Same way as it worked for the svn version and like the "official" angband binary version in Archlinux is built.

Still have a working dev version installed, so no hurry Just wanted to make sure that you guys are aware of it since the autobuilder doesn't seem to work atm.

[Magnate]

Originally Posted by SaThaRiel

I pulled from github.com/angband/angband.git (already existing repository) and also did a git clone (removed repository to start over).
The build is done this way

  ./autogen.sh
  ./configure \
    --prefix=/usr \
    --bindir=/usr/bin/ \
    --sysconfdir=/usr/share/angband \
    --with-configpath=/usr/share/angband \
    --with-libpath=/usr/share/angband \
    --enable-gtk \
    --enable-sdl \
	--enable-sdl-mixer || return 1
  make clean
  make

Same way as it worked for the svn version and like the "official" angband binary version in Archlinux is built.

Still have a working dev version installed, so no hurry Just wanted to make sure that you guys are aware of it since the autobuilder doesn't seem to work atm.

Ok, I can confirm that I get the same error as you when compiling main-gtk.c in the current master branch. Apologies - we should have caught this before committing it to master. Will try to fix ASAP.

[Magnate]

Ok, this is fixed in staging, but cannot be committed to master until some other bugs have been fixed in staging. Pls bear with us.

[SaThaRiel]

Better take your time fixing bugs instead of hurry and built in some more

[Magnate]

Originally Posted by SaThaRiel

Better take your time fixing bugs instead of hurry and built in some more

Right, it's finally fixed. Took about four hours longer than I was expecting, but got there in the end. We should get a working version autobuilt tonight. Pls report any bugs ASAP because we're moving towards a release now.

[SaThaRiel]

The compile looks good, only one warning anymore

generate.c: In function ‘cave_gen’:
generate.c:2898:10: warning: ‘bx’ may be used uninitialized in this function
Successfully compiled generate.c.

Not sure, but if you sell and buy items, the last message is repeated when you leave the shop or press some key. Don't know how to describe it better, but its a bit anoying. But maybe its the wanted behaviour or a new option? Or its just a bug

[Magnate]

Originally Posted by SaThaRiel

The compile looks good, only one warning anymore

generate.c: In function ‘cave_gen’:
generate.c:2898:10: warning: ‘bx’ may be used uninitialized in this function
Successfully compiled generate.c.

Not sure, but if you sell and buy items, the last message is repeated when you leave the shop or press some key. Don't know how to describe it better, but its a bit anoying. But maybe its the wanted behaviour or a new option? Or its just a bug

The latter is a known bug of the recent store UI changes, which I've just recorded on trac as #1203.

The compiler warning is odd because I don't get it at all. What version of gcc are you using? Did you get any unusual output when you ran ./autogen.sh or ./configure? What arguments did you give ./configure? I will see if I can reproduce it by duplicating your build invocations.