Feature Request: unrecognized sval repair

[Deof Movestofca]

Originally Posted by Magnate

It may well have been there all the time, but not read in until you appended your changes to the file. Did that solve the problem?

It was a new character, so I went ahead and simply decided to delete and start over. However, it's happening again with the Iron Spikes, except at Line 407, column 5: "K:spike:Iron Spike~:25:222". Changed the line to "K:spike:& Iron Spike~:25:222" and no joy. Just to make sure, I removed the space ("K:spike:&Iron Spike~:25:222") and it still doesn't work. I even tried "K:spike:Iron~ Spike:25:222", a la "Flask~ of oil" and "Piece~ of Elvish Waybread".

[Derakon]

The ~ indicates where the pluralization goes, so "Iron Spikes", "Flasks of Oil", "Pieces of Elvish Waybread", etc. The & is for the article/quantity ("an Iron Spike", "26 Flasks of Oil", etc.), which is why it appears at the beginning of practically every "non-flavored" item in object.txt.

[Deof Movestofca]

1) So you mean you can't have Irons Spike?
2) Just curious as to why "Iron Spike~" would require an ampersand in front of it when a search of the .prf file doesn't show any others?

[takkaria]

Originally Posted by Deof Movestofca

1) So you mean you can't have Irons Spike?
2) Just curious as to why "Iron Spike~" would require an ampersand in front of it when a search of the .prf file doesn't show any others?

Heh, well. So a long time ago the pref files were basically unreadable because they had the format:

K:number in object.txt:graphic

which in practice looked like

K:533:0x44:0x76

Which reads like an ancient rite in a long-forgotten archaic form of magic.

So I moved us to using

K:tval name:sval name:graphic

Which is a lot more readable, but you had to inlcude & at the beginning of basically every item. So I added code to ignore that bit, and, more recently, always use the singular form of the name so you don't use the ~ anymore. But the pref file writing code hasn't caught up, and while it omits '&' it doesn't omit the plural signifier, ~.

IOW, my bad, I've got a fix locally and I'll push it to github ASAP. Thanks for the bug report!

[Deof Movestofca]

Originally Posted by takkaria

...which in practice looked like

K:533:0x44:0x76

Which reads like an ancient rite in a long-forgotten archaic form of magic.

So I moved us to using

K:tval name:sval name:graphic

Which is a lot more readable...

Sorry, but to us non-programmers, it still looks like a long-forgotten archaic form of magic. If it conjures up drolems, I'm outta here.

Looking forward to the fix.

[Derakon]

Sounds like the workaround for now is to remove all the "~"s from the file. Is that right, Takkaria?

[takkaria]

Originally Posted by Derakon

Sounds like the workaround for now is to remove all the "~"s from the file. Is that right, Takkaria?

Yes, that's right.